Skip to content

FOUR-26817 Different behaviors to add conditions#1946

Merged
caleeli merged 4 commits into
feature/FOUR-26707from
FOUR-26817
Oct 1, 2025
Merged

FOUR-26817 Different behaviors to add conditions#1946
caleeli merged 4 commits into
feature/FOUR-26707from
FOUR-26817

Conversation

@devmiguelangel

@devmiguelangel devmiguelangel commented Oct 1, 2025 •
edited by cursor Bot
Loading

Copy link
Copy Markdown
Contributor

Issue & Reproduction Steps

Different behaviors to add conditions

When conditions are not met, then which task destination element is displayed

Solution

  • Validate condition limit handling for max conditions on duplicate
  • Update conditional redirect description and task source label

Related Tickets & Packages

FOUR-26817
FOUR-26818

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

Note

Enforces the max condition limit (incl. duplicates), updates the conditional redirect description and Task Source label, propagates max-state to child, and adds comprehensive E2E tests.

  • UI/Logic (Conditional Redirect):
    • Replace static helper text with computed conditionalRedirectDescription using v-html; bolds Task Destination.
    • Add computed maxConditionsReached; use it to disable Add and Duplicate actions and to gate duplication logic.
    • Pass maxConditionsReached to TaskDestination and consume it to disable the Duplicate button.
    • Refactor checks to use maxConditionsReached in addCondition and onDuplicateCondition.
  • Config:
    • Update option label: taskSource from Task Source (Default) to Task Source.
  • Tests (E2E):
    • Add conditionalRedirect/Tasks.cy.js covering setting destinations, max conditions reached, duplicating, and removing conditions.

Written by Cursor Bugbot for commit 051ded0. This will update automatically on new commits. Configure here.

@devmiguelangel devmiguelangel self-assigned this Oct 1, 2025
cursor[bot]
cursor Bot reviewed Oct 1, 2025
View reviewed changes

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is being reviewed by Cursor Bugbot

Details

Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.

To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.

@devmiguelangel devmiguelangel changed the title FOUR-26817 FOUR-26817 Different behaviors to add conditions Oct 1, 2025
@ProcessMaker ProcessMaker deleted a comment from cursor Bot Oct 1, 2025
@cypress

cypress Bot commented Oct 1, 2025 •
edited
Loading

Copy link
Copy Markdown

modeler    Run #1684

Run Properties:  status check passed Passed #1684  •  git commit 60187dab22: FOUR-26817 Different behaviors to add conditions
Project modeler
Branch Review FOUR-26817
Run status status check passed Passed #1684
Run duration 05m 44s
Commit git commit 60187dab22: FOUR-26817 Different behaviors to add conditions
Committer Miguel Angel
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 83
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 285
View all changes introduced in this branch ↗︎

@processmaker-sonarqube

processmaker-sonarqube Bot commented Oct 1, 2025

Copy link
Copy Markdown

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@caleeli caleeli merged commit fd0055c into feature/FOUR-26707 Oct 1, 2025
87 of 103 checks passed
@caleeli caleeli deleted the FOUR-26817 branch October 1, 2025 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cursor cursor[bot] cursor[bot] left review comments
@caleeli caleeli caleeli approved these changes
@rodriquelca rodriquelca Awaiting requested review from rodriquelca

Assignees

@devmiguelangel devmiguelangel

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@devmiguelangel @caleeli